-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bugs/Issues of PowerFlow #45
Conversation
@GabrielKS @jd-lara The bug in the Q redistribution was that the units was hitting limits in iterative process of the remaining Q, but it was not correctly substracted to the residual in that case. This was fixed by replacing |
Regarding the tests: Tests are failing for the net_flows with the update of #41. @GabrielKS @jd-lara Let me know if we are OK with adding the symmetrical and I will update the tests to change the zeros for negative values if needed, or going back to only having one direction and the other zero. |
I like the new behavior you have implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from the test failures.
@GabrielKS It is ready for review. There is now one kwarg when calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #44 #43 #40 #41